Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic typings acquisition tries to uses non-existant version of npm if run from a version of node that does not include npm #30909

Closed
mjbvz opened this issue Apr 13, 2019 · 0 comments · Fixed by #30910
Closed

Automatic typings acquisition tries to uses non-existant version of npm if run from a version of node that does not include npm #30909

mjbvz opened this issue Apr 13, 2019 · 0 comments · Fixed by #30910
Assignees
@mjbvz
Labels
Bug A bug in TypeScript
Milestone
TypeScript 3.4.5

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 13, 2019 •
edited
Loading

TypeScript Version: 3.5.0-dev.20190412

Repo

  1. On a machine that has a global version of node and npm installed
  2. Spawn the TS Server using a version of node that does not include npm
  3. Trigger automatic type acquisition

Bug
See ATA fail. This is because ATA will try to use the version of npm that is next to the version of node that it is being run by
@mjbvz mjbvz self-assigned this Apr 13, 2019
@mjbvz mjbvz mentioned this issue Apr 13, 2019
Merged
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Apr 15, 2019
@RyanCavanaugh RyanCavanaugh mentioned this issue Apr 18, 2019
Merged
RyanCavanaugh added a commit that referenced this issue Apr 19, 2019
@RyanCavanaugh
Port #30910 to release-3.4 (#31024)
85241c3 
Fixes #30909 by porting #30910
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.4.5 milestone Apr 24, 2019
This was referenced Sep 24, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
Bug A bug in TypeScript
Projects
None yet
Milestone
TypeScript 3.4.5
Development

Successfully merging a pull request may close this issue.

Check to make sure default npm exists at path before trying to use it mjbvz/TypeScript
3 participants
@DanielRosenwasser @RyanCavanaugh @mjbvz