Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL var is declared multiple times in lib files #5306

Closed
myitcv opened this issue Oct 17, 2015 · 3 comments
Closed

URL var is declared multiple times in lib files #5306

myitcv opened this issue Oct 17, 2015 · 3 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@myitcv
Copy link

myitcv commented Oct 17, 2015

$ grep -n 'declare var URL' lib/*
lib/lib.dom.d.ts:10903:declare var URL: URL;
lib/lib.dom.d.ts:12945:declare var URL: URL;
lib/lib.d.ts:14727:declare var URL: URL;
lib/lib.d.ts:16769:declare var URL: URL;
lib/lib.es6.d.ts:16042:declare var URL: URL;
lib/lib.es6.d.ts:18084:declare var URL: URL;

Just saw that #5293 was merged; happy to submit a PR unless these files are generated in some way?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 17, 2015

@zhengbli can you take a look.

@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this and removed Help Wanted You can do this labels Oct 17, 2015
@mhegazy mhegazy added the Help Wanted You can do this label Dec 8, 2015
@mhegazy mhegazy added this to the Community milestone Dec 8, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Dec 8, 2015

PRs are welcomed. here is some details about submitting changes to lib.d.ts: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

@myitcv
Copy link
Author

myitcv commented Apr 12, 2016

This is fixed as of 1.9.0-dev.20160408:

$ npm install typescript@1.9.0-dev.20160408
...
$ grep -n 'declare var URL' node_modules/typescript/lib/* | grep dom\.d\.ts
node_modules/typescript/lib/lib.dom.d.ts:11765:declare var URL: {

@zhengbli the only outstanding issue then is #7619 (comment). I'll create an issue to track that

@myitcv myitcv closed this as completed Apr 12, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 12, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.0, Community Apr 12, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

2 participants