Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there some good approach to remove 'readonly' restriction templorary from fields? #6717

Closed
tetsuharuohzeki opened this issue Jan 29, 2016 · 4 comments
Labels
Question An issue which isn't directly actionable in code

Comments

@tetsuharuohzeki
Copy link
Contributor

environment

  • typescript@1.9.0-dev.20160128

description

relate? : #6532

In some case (e.g. to development framework), I'd like to do a destruct operation for the members which is restricted as readonly to release a some large object explicitly. But it would be the compile error if I assign a value to the restricted member in a non-constructor() method.

class A {
  readonly a: SomeLargeObject;
  constructor(a: SomeLargeObject) {
    this.a = a;
  }

  // explicit destructor
  destroy(): void {
    // release this some large object explicitly
    this.a = null; // <-- compile error
    (<any>this).a = null; // <-- no problem
    (<MutableA>this).a = null // <--- no problem
  }
}

interface MutableA {
  a: SomeLargeObject;
}

I know we can avoid this error if casting this to any type, but it would not be a type safe. In other approach, we can also do it if we define a "mutable" interface and cast to it, but it would be wordy....

Are there some good approach to remove 'readonly' restriction templorary?

@ahejlsberg
Copy link
Member

I'd propose using a public get accessor with a private backing field. There's no way to temporarily remove readonly as that would sort of defeat the purpose of the feature.

@ahejlsberg ahejlsberg added the Question An issue which isn't directly actionable in code label Jan 29, 2016
@mhegazy mhegazy closed this as completed Jan 29, 2016
@tetsuharuohzeki
Copy link
Contributor Author

I'd propose using a public get accessor with a private backing field.

I also thought the following usecase, so its escape hatch is like a C++'s const_cast<T>()
The public get accessor is defensive from external operation, but it cannot guard from internal operation.

class B {
   // I'd not like to modify this field only in a constructor/destructor
   private b: SomeLargeObject;

   constructor(b: SomeLargeObject) {
      this.b = SomeLargeObject;
   }

   bar(): void {
     var blahblah = createSomeLargeObject();
     this.b = blahblah; // I'd like to ban this operation.
   } 

   destroy(): void {
      this.b = null; // I'd like to allow this.
   }
}

@pablobirukov
Copy link

@saneyuki This is allowed in 2.0.3

public destroy() {
    delete this.scheduler; 
    delete this.stream;
    ...
}

@mhegazy
Copy link
Contributor

mhegazy commented Oct 18, 2016

@R00GER ideally this should be reported as an error. deleting should follow the same rules as writing. #11480 tracks making this an error.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Question An issue which isn't directly actionable in code
Projects
None yet
Development

No branches or pull requests

4 participants