Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10967, allow boolean flags to have explicit value #11798

Merged
merged 2 commits into from
Oct 24, 2016

Conversation

HerringtonDarkholme
Copy link
Contributor

@HerringtonDarkholme HerringtonDarkholme commented Oct 23, 2016

@@ -1,4 +1,4 @@
/// <reference path="..\harness.ts" />
/// <reference path="..\harness.ts" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the diff here? BOM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. -<U+FEFF>/// <reference path="..\harness.ts" /> reported in git command line

@RyanCavanaugh
Copy link
Member

👍

@mhegazy mhegazy merged commit 287b545 into microsoft:master Oct 24, 2016
@HerringtonDarkholme HerringtonDarkholme deleted the boolean-flags branch January 8, 2017 10:11
jasssonpet added a commit to NativeScript/nativescript-dev-typescript that referenced this pull request Jan 11, 2017
jasssonpet added a commit to NativeScript/nativescript-dev-typescript that referenced this pull request Jan 11, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants