Missing property fix #14097
Merged
Missing property fix #14097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Feb 16, 2017
| const binaryExpression = token.parent.parent as BinaryExpression; | ||
|
|
||
| const checker = context.program.getTypeChecker(); | ||
| const widenedType = checker.getBaseTypeOfLiteralType(checker.getTypeAtLocation(binaryExpression.right)); |
There was a problem hiding this comment.
you also want to widen it. i.e. null => any
mhegazy
approved these changes
Feb 16, 2017
DanielRosenwasser
requested changes
Feb 16, 2017
| }] | ||
| }, | ||
| { | ||
| description: formatStringFromArgs(getLocaleSpecificMessage(Diagnostics.Add_index_accessor_for_missing_property_0), [token.getText()]), |
There was a problem hiding this comment.
- "index accessor" -> "index signature"
- You either need a test for this fix, or you should get rid of it.
There was a problem hiding this comment.
changed and test added
mhegazy
approved these changes
Feb 16, 2017
|
@aozgaa after merging in master please port this to release-2.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #13071.
Note that there is considerably more work to do for stubbing out missing methods if we want to do any type inference on the parameters. There are additionally issues with inferring type parameters for the stubbed method from its type arguments.
Thoughts @mhegazy @billti @DanielRosenwasser ?