Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api review cleanup #2692

Merged
merged 10 commits into from
Apr 11, 2015
Merged

Api review cleanup #2692

merged 10 commits into from
Apr 11, 2015

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Apr 9, 2015

Based on the API discussion yesterday, this removes the typescript_internal.d.ts and only uses the @internal comment to remove no public APIs.

I have marked everything we did not talk about as internal for now. the only changes I have made is exposing:

Tip: look at bin\typescript.d.ts to see what changed in the public API surface area.

@@ -1,5 +1,6 @@
/// <reference path="binder.ts" />

/** @internal */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being picky, could we use same syntax between this. We use both /** @internal / and / @internal */

@CyrusNajmabadi
Copy link
Contributor

👍

mhegazy added a commit that referenced this pull request Apr 11, 2015
@mhegazy mhegazy merged commit 5f5cdda into master Apr 11, 2015
@mhegazy mhegazy deleted the APIReviewCleanup branch April 11, 2015 01:09
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants