Adding saturation and a simpler way to add more effects #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltakosh
reviewed
Mar 10, 2017
docs/animations/Saturation.md
Outdated
| ```xml | ||
|
|
||
| <interactivity:Interaction.Behaviors> | ||
| <behaviors:Blur x:Name="SaturationBehavior" |
There was a problem hiding this comment.
good spot! updated.
deltakosh
approved these changes
Mar 10, 2017
nmetulev
requested changes
Mar 16, 2017
| public class Saturation : CompositionBehaviorBase | ||
| { | ||
| /// <summary> | ||
| /// The Blur value of the associated object |
There was a problem hiding this comment.
Should this be Saturation in the comments?
| /// Gets or sets the Blur. | ||
| /// </summary> | ||
| /// <value> | ||
| /// The Blur. |
Correcting typos
|
updating the typos. Good spot. |
nmetulev
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simpler way to add effects. I've added saturation as an example and moved blur to follow too. It should also solve #919