Add method to get translation language names #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
reviewed
May 15, 2017
| var doc = XDocument.Parse(content); | ||
| var detectedLanguage = doc.Root.Value; | ||
|
|
||
| return detectedLanguage; |
There was a problem hiding this comment.
This is a cool feature. Just wondering, is it possible to return a ServiceLanguage here too?
There was a problem hiding this comment.
Yes, it is surely possible, but another call to the service will be necessary for each detection, unless I keep a local cache of all the Language Names. Otherwise, you need to manually call GetLanguageNamesAsync method and then keep the ServiceLanguage list in our app, in order to retrive the full name corresponding to the detected language.
There was a problem hiding this comment.
That makes sense to me, let's keep it like this :)
nmetulev
approved these changes
May 15, 2017
|
Merging but requires documentation so adding an issue for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TranslatorService now contains a new method that can be used to automatically get friendly language names.