Added HamburgerMenu.PaneForeground to address theming problem #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KarlErickson, It will cover your contributions to all .NET Foundation-managed open source projects. |
|
@KarlErickson, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Ran into this issue as well this weekend, fix seems good. |
nmetulev
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Foreground to set the hamburger button color blocks theme inheritance in the content frame. This PR adds a PaneForeground property that targets the button but not the content frame, and defaults to the Foreground value so it won't break current Foreground usage.