Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing max RegexTextbox Email Validation from 3 Character domain name to unlimited. #1192

Merged
merged 1 commit into from
May 31, 2017

Conversation

avknaidu
Copy link
Member

See Issue #1191

@skendrot
Copy link
Contributor

skendrot commented May 30, 2017

Should there be a max? The current longest TLD is 18 characters (.travelersinsurance)

@avknaidu
Copy link
Member Author

@skendrot , the reason why i wanted this to be empty because if at all if in future TLD is increased, it will not affect the control.

@skendrot
Copy link
Contributor

I agree, but do we think a max of 25-30-50 makes sense? Or just leave it at max?

@avknaidu
Copy link
Member Author

avknaidu commented May 30, 2017

after your comment, i did a little search on longest TLD's and found this. According to this post, at the time of writing ( Aug 7 2015), it was 14 characters long, But if you scroll all the way to end, you can see some with 24 characters.

My gut says give a max of 30.

@skendrot
Copy link
Contributor

I used Wikipedia to find the longest. I did not count the xn-- DNS names because the actual TLD are Chinese characters

@avknaidu
Copy link
Member Author

So shall i update it to 30?

@skendrot
Copy link
Contributor

I would prefer to see a max, but I would not say it's a requirement. Would love to know other thoughts as well. @nmetulev @IbraheemOsama

@nmetulev
Copy link
Contributor

I'm ok with it not having a max If there is no max requirement for TLDs. Is there a downside with no max?

@nmetulev nmetulev added this to the v1.5 milestone May 30, 2017
@skendrot
Copy link
Contributor

TLDs have to be approved. One cannot just create their own TLD. However, it seems that any TLD is getting approved these days!

@nmetulev
Copy link
Contributor

Exactly my point :)

Copy link
Contributor

@skendrot skendrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against .ca, .com, .aero, .supercalifragilisticexpialidocious
All worked fine

@nmetulev nmetulev merged commit 9374554 into CommunityToolkit:dev May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants