MasterDetailsView: fixed loaded bug #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenchauhan
requested changes
May 31, 2017
| _stateGroup = (VisualStateGroup)GetTemplateChild(WidthStates); | ||
| if (_stateGroup != null) | ||
| { | ||
| _stateGroup.CurrentStateChanged += OnVisualStateChanged; |
There was a problem hiding this comment.
You need to unwire this when it's unloaded.
|
Not arguing that this needs to be fixed, but why would the view be set to collapsed? Is x:DeferLoad a better approach for whatever you're trying to do? |
skendrot
approved these changes
May 31, 2017
|
@skendrot, agree on setting x:Load vs Visibility, that should definitely be the right approach. |
shenchauhan
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initial visibility of MasterDetailsView is collapsed, Loaded gets called before template is applied, and an exception is thrown. This fix should resolve the issue.