DropShadowPanel Content wireup size changed #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
reviewed
Jul 11, 2017
|
|
||
| if (content != null) | ||
| { | ||
| content.SizeChanged += OnSizeChanged; |
There was a problem hiding this comment.
In addition, should we handle the ContentChanged event to unsubscribe/subscribe events and avoid memory leaks?
There was a problem hiding this comment.
@nmetulev good spot.. let me try hooking into OnContentChanged
There was a problem hiding this comment.
@nmetulev changes have been pushed.
…ntent's size changed there.
nmetulev
approved these changes
Jul 12, 2017
IbraheemOsama
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire up DropShadowPanel Content's size change to ensure that shadow is updated correctly.
Address #1111 and #1299