-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistakes in docs #1354
Mistakes in docs #1354
Conversation
Corrected MarkdownTextBlock Example Code, Default Template and API Links
@Vijay-Nirmal, It will cover your contributions to all .NET Foundation-managed open source projects. |
Corrected SlidableListItem Default Template link and Slidable spelling mistake
Corrected HttpHelper API link and changed HttpHelperRequest source code to HttpHelper source code
@Vijay-Nirmal, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Corrected HttpHelperResponse API Link and changed HttpHelperRequest source code to HttpHelperResponse source code
|
TextBoxMask, TextBoxRegex and WrapPanel has no default template because TextBoxMask, TextBoxRegex are attached properties and WrapPanel is a Panel :) Will have a look to get back with answers for AdaptiveGridView and the requirements for BindableValueHolder, DeepLinkParsers and NotificationsOverview |
Placed ExpressionBuilder in the second position to mention ascending order in readme.md
I unknowingly removed Bullets in my previous Commit. So I added back
@IbraheemOsama Shall I update Menu Sample Image to a Gif? Current one is not even a Sample Image, It looks like Logo |
@Vijay-Nirmal if you can do that would be amazing :) |
Does #1297 and this PR affect each other? |
No, it shouldn't because you're working the documentation and the other is touching code. |
@Vijay-Nirmal, |
Clicked close by mistake :( there should be a confirmation on clicking close |
Can anyone verify the below info?
|
@Vijay-Nirmal, looks correct |
|
@Vijay-Nirmal some extensions are moved to other namespaces in PR #1297 and doc/sample links are corrected. |
@Vijay-Nirmal on AdaptiveGridView, I'd remove the section on default template. |
@nmetulev How do I Resolve conflicts? |
@edwinvandriel You didn't add the New Nuget Package(Microsoft.Toolkit.Uwp.UI.Extensions) in Nuget-Packages.md and readme.md. Shall I add it in this PR? |
@Vijay-Nirmal, to resolve conflict, you will need to merge with dev and manually resolve the conflicts in the files. Oh, and there is no new Nuget Package, the extensions are still under the Microsoft.Toolkit.Uwp.UI package |
@nmetulev Is there a way that you can help me or it's up to me to resolve conflict? |
I can help if you need it, can you give me write access to your fork/branch? |
@Vijay-Nirmal, I resolved conflicts, please make sure everything looks good. Once you are ready, we can review. |
@nmetulev Look good until I find a new mistake. Also, Thanks for resolving conflicts |
@Vijay-Nirmal Congrats your first PR just got merged :) |
#1226
UWP Community Toolkit Nuget Packages - Update Package detailsExpressionBuilder Namespace, API - No API link and No Namespace mentionedDoc(Expression): Adding all info from original doc #1366