Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(Expression): Adding all info from original doc #1366

Merged
merged 3 commits into from
Aug 8, 2017

Conversation

Vijay-Nirmal
Copy link
Contributor

@dnfclas
Copy link

dnfclas commented Aug 2, 2017

@Vijay-Nirmal,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link
Contributor

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about leaving the quick getting started section at the beginning and then adding the larger documentation bellow. That might make it easier to get started instead of having to read the larger documentation

@@ -1,144 +1,960 @@
# ExpressionBuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, There should still be a title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I will do it

@Vijay-Nirmal
Copy link
Contributor Author

@nmetulev What do mean by "leaving the quick getting started section"? Do you mean the previous Doc or Should I create a quick start section?

@Vijay-Nirmal Vijay-Nirmal mentioned this pull request Aug 7, 2017
23 tasks
@nmetulev
Copy link
Contributor

nmetulev commented Aug 7, 2017

The previous doc had some great info on how to quickly get started which I think is very valuable and should still be there. Either as a quick start section or as intro to the entire doc.

@skendrot skendrot merged commit 4febfc0 into CommunityToolkit:dev Aug 8, 2017
@Vijay-Nirmal Vijay-Nirmal deleted the ExpressionDoc branch November 23, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants