Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.Toolkit.Uwp.Connectivity #1382

Merged
merged 20 commits into from
Aug 21, 2017
Merged

Add Microsoft.Toolkit.Uwp.Connectivity #1382

merged 20 commits into from
Aug 21, 2017

Conversation

hermitdave
Copy link
Contributor

Add Microsoft.Toolkit.Uwp.Connectivity and move BT LE and Network helpers there.
Addressing #1371

Copy link
Contributor

@Odonno Odonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@nmetulev
Copy link
Contributor

The build seems to be failing :(

@hermitdave
Copy link
Contributor Author

I'll take a look. Thanks

@Odonno
Copy link
Contributor

Odonno commented Aug 17, 2017

@hermitdave @nmetulev Sorry for not seeing the CI failed during my first review. I do not see anything special to do anymore. @nmetulev did the job.

@hermitdave
Copy link
Contributor Author

@Odonno the CI issue appeared after I merged with latest dev (after merging bing service more to .net standard)

Thanks @nmetulev

@IbraheemOsama
Copy link
Member

@nmetulev @hermitdave there is some conflicts here.
LGTM, I'll approve it and once the conflict is resolved we can merge it

@nmetulev nmetulev merged commit 7df1951 into dev Aug 21, 2017
@nmetulev nmetulev deleted the Connectivity-HD branch August 21, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants