Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1167: Update Converter Docs #1395

Merged

Conversation

michael-hawker
Copy link
Member

List all converters and provide examples of other core converter scenarios.

…verters and provide examples of other core converter scenarios.
@dnfclas
Copy link

dnfclas commented Aug 17, 2017

@michael-hawker,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Vijay-Nirmal
Copy link
Contributor

It would be nice to have a third column to give 1 or 2 line code sample to each type of converters

@michael-hawker
Copy link
Member Author

@Vijay-Nirmal I feel like a snippet like that would be the same for most converters Property="{Binding Path=SomeValue, Converter={StaticResource SomeConverter}}".

Is there a scenario missing from the new ones below that you feel we should elaborate on?

@IbraheemOsama IbraheemOsama merged commit d443528 into CommunityToolkit:dev Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants