Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VSToolsManifest so controls will show up in the toolbox #1466

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

dotMorten
Copy link
Contributor

Addresses #1464

@dotMorten dotMorten self-assigned this Aug 31, 2017
@nmetulev nmetulev changed the base branch from dev to master September 1, 2017 03:57
@Odonno
Copy link
Contributor

Odonno commented Sep 1, 2017

@dotMorten How do you set the icon for each control in the toolbox?

@dotMorten
Copy link
Contributor Author

dotMorten commented Sep 1, 2017

@Odonno I'm currently not, but there's a few ways to do it as described here: https://docs.microsoft.com/en-us/nuget/guides/create-uwp-controls

We can create a follow-up issues to add icons. The odd thing is though... a couple of the controls somehow gets icons. No idea where those came from, but I'm thinking it's a bug since it looks like it might be pulling them from WPF icons where the name matches.

Copy link
Contributor

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected

@dnfclas
Copy link

dnfclas commented Sep 1, 2017

@dotMorten, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@IbraheemOsama IbraheemOsama merged commit 40359f5 into master Sep 6, 2017
@dotMorten dotMorten deleted the Morten/1464_IntegrateWithVSToolbox branch September 9, 2017 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants