Added comments and fixed stylecop warnings #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbraheemOsama
approved these changes
Oct 11, 2017
dotMorten
approved these changes
Oct 11, 2017
| @@ -486,14 +495,29 @@ public static void AddAnimation(Storyboard storyboard, DependencyObject element, | |||
| /// </summary> | |||
| public struct Proj | |||
| { | |||
| /// <summary> | |||
| /// Position of an item | |||
There was a problem hiding this comment.
The correct property wording is "Gets or sets the [blah]" (same for the ones below)
| @@ -34,11 +34,15 @@ namespace Microsoft.Toolkit.Uwp.UI.Controls | |||
| [ContentProperty(Name = "Content")] | |||
| public partial class Expander : ContentControl | |||
| { | |||
| /// <summary> | |||
| /// Default constructor for the Expander control | |||
There was a problem hiding this comment.
The proper constructor wording is Initializes a new instance of the <see cref="Expander" /> class @
| @@ -22,12 +22,21 @@ namespace Microsoft.Toolkit.Uwp.UI.Controls.TextToolbarFormats | |||
| /// </summary> | |||
| public abstract class Formatter | |||
| { | |||
| /// <summary> | |||
| /// Constructor for the <see cref="Formatter"/> class | |||
There was a problem hiding this comment.
Non-standard constructor wording
| @@ -14,28 +14,39 @@ | |||
|
|
|||
| namespace Microsoft.Toolkit.Uwp.UI.Controls.TextToolbarFormats.MarkDown | |||
| { | |||
| /// <summary> | |||
| /// Class defining actions for MarkDown | |||
| public class MarkDownButtonActions : ButtonActions | ||
| { | ||
| /// <summary> | ||
| /// Constructor for the <see cref="MarkDownButtonActions"/> |
IbraheemOsama
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1451
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Too many compiler warnings caused by missing comments and other stylecop formatting rules
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Warnings for missing comments and stylecope warnings have been removed
Does this PR introduce a breaking change?
Other information