Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links in readme #1554

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Conversation

ktos
Copy link
Contributor

@ktos ktos commented Oct 15, 2017

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ x ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

Link to PrinterHelper was obviously wrong, resulting in 404 and should be PrintHelper.

However, other links to www.uwpcommunitytoolkit.com were randomly (sometimes, not always) giving me 404, while there is no such problem with docs.uwpcommunitytoolkit.com.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [ x ] Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

Links are correct :)

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

While PrinterHelper was obviously wrong and should be PrintHelper,
other links to www.uwpcommunitytoolkit.com were randomly giving
me 404, while there is no such problem with docs.uwp...
@dnfclas
Copy link

dnfclas commented Oct 15, 2017

@ktos,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link
Contributor

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these

@nmetulev nmetulev merged commit e587b05 into CommunityToolkit:master Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants