Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked touch and mouse pull to refresh behavior to match, can now scroll with mouse #1564

Merged
merged 3 commits into from
Nov 10, 2017

Conversation

nmetulev
Copy link
Contributor

@nmetulev nmetulev commented Oct 21, 2017

Issue: #1034 #1380 #887

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

See #1034 #1380 #887

PR Checklist

Please check if your PR fulfills the following requirements:

What is the new behavior?

  • Mouse and touch have the same behavior now when pulling down
  • When IsPullToRefreshWithMouseEnabled set to true, the mouse will scroll the listview
  • System manipulations (such as swiping on a pivot) works even when mouse pull to refresh is enabled

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@nmetulev nmetulev changed the title Tweaked touch and mouse pull to refresh behavior to match Tweaked touch and mouse pull to refresh behavior to match, can now scroll with mouse Oct 21, 2017
@shenchauhan shenchauhan merged commit 45e65a8 into master Nov 10, 2017
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #887, #1034, #1380

@nmetulev nmetulev deleted the nmetulev/pulltorefresh branch November 10, 2017 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants