Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expression builder classes #1579

Merged
merged 19 commits into from
Nov 9, 2017

Conversation

skendrot
Copy link
Contributor

@skendrot skendrot commented Oct 30, 2017

Issue: #1578

PR Type

Change to use the new expression builder classes for all expression animations

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[x] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@skendrot
Copy link
Contributor Author

@samoteph Can you make sure the TileControl still works as expected. All functionality in the sample app continues to work but the expressions are rather complex so would love your eyes on them.

Copy link
Contributor

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - works as expected

Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, seems to be working fine and has the same behavior before and after the changes!

@skendrot
Copy link
Contributor Author

skendrot commented Nov 2, 2017

@samoteph Any thoughts on the tile control?

@skendrot skendrot merged commit 5c1cfa8 into CommunityToolkit:master Nov 9, 2017
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1578

@skendrot skendrot deleted the UseExpressionBuilder branch November 9, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants