-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use expression builder classes #1579
Use expression builder classes #1579
Conversation
@samoteph Can you make sure the TileControl still works as expected. All functionality in the sample app continues to work but the expressions are rather complex so would love your eyes on them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, seems to be working fine and has the same behavior before and after the changes!
@samoteph Any thoughts on the tile control? |
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1578 |
Issue: #1578
PR Type
Change to use the new expression builder classes for all expression animations
What is the current behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Does this PR introduce a breaking change?
Other information