Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the style of the Expander to respect the border properties #1585

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

skendrot
Copy link
Contributor

Issue: #1583

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

Fixes issue where the Expander control does not respect the Border* properties

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

The Expander control will now honor the Border* properties

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR changes the Style of the Expander by replacing a Grid with a Border

@skendrot skendrot requested a review from Odonno October 31, 2017 21:53
@azchohfi
Copy link
Contributor

Wow... talk about timing... I was reporting an issue that just got fixed by this PR. Changing the Background color of the Expander was changing the background color of the header even when it was expanded. This also fixed this bug. Thanks @skendrot.

@azchohfi
Copy link
Contributor

Can you just pull the latest changes from master, just to double check that this does not conflict with the other PR that also changed the expander.

@azchohfi azchohfi merged commit 1502f0f into CommunityToolkit:master Oct 31, 2017
@azchohfi
Copy link
Contributor

It was working, I double checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants