Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with saturation being overriden #1591

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

shenchauhan
Copy link
Contributor

Issue: #1410

PR Type

What kind of change does this PR introduce?
Bug Fix

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

stops saturation overriding itself incorrectly #1410

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] Tested code with current supported SDKs
  • Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

Fixes the issue

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@michael-hawker
Copy link
Member

It'd be great to have a bit more detail on how this resolves the issue (i.e. what the actual problem with the logic was beforehand in this scenario) vs. 'fixes the issue'.

I'm not super familiar with this code, but it's not obvious what this if statement was doing at the end and how modifying it solves the problem.

@azchohfi azchohfi self-requested a review November 7, 2017 23:22
@azchohfi azchohfi merged commit 651e031 into CommunityToolkit:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants