Headered controls #1599

skendrot · 2017-11-07T17:43:08Z

Issue: #995

PR Type

What kind of change does this PR introduce?
Add HeaderedContentControl and HeaderedItemsControl

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Docs have been added / updated (for bug fixes / features)
Sample in sample app has been added / updated (for bug fixes / features)
Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

…ect Border properties

…ontrol

nmetulev · 2017-11-07T18:34:24Z

Microsoft.Toolkit.Uwp.UI.Controls/HeaderedContentControl/HeaderedContentControl.xaml

+    xmlns:controls="using:Microsoft.Toolkit.Uwp.UI.Controls">
+    <Style TargetType="controls:HeaderedContentControl">
+        <Setter Property="HorizontalContentAlignment" Value="Left"/>
+        <Setter Property="VerticalContentAlignment" Value="Top"/>


Just curious, why not stretch for these two values?

Follows the style of the ContentControl

This will be in the documentation. As will information about why the Border* properties are not respected (b/c the ContentControl and ItemsControl do not)

nmetulev · 2017-11-07T18:36:16Z

Microsoft.Toolkit.Uwp.UI.Controls/HeaderedContentControl/HeaderedContentControl.cs

+        {
+        }
+
+        private static void OnHeaderChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)


Doesn't look like this is referenced anywhere

nmetulev · 2017-11-07T18:36:30Z

Microsoft.Toolkit.Uwp.UI.Controls/HeaderedContentControl/HeaderedContentControl.cs

+        /// </summary>
+        /// <param name="oldValue">The old value of the <see cref="Header"/> property.</param>
+        /// <param name="newValue">The new value of the <see cref="Header"/> property.</param>
+        protected virtual void OnHeaderChanged(object oldValue, object newValue)


Is this needed?

Following API from WPF

nmetulev · 2017-11-07T18:36:55Z

Microsoft.Toolkit.Uwp.UI.Controls/HeaderedItemsControl/HeaderedItemsControl.cs

+        {
+        }
+
+        private static void OnHeaderChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)


Is this needed?

Following API from WPF

nmetulev · 2017-11-07T22:49:50Z

Looks good to me (other than the missing docs) :)

Odonno

This is a pretty good addition to the Toolkit. I left some comments but it seems good to me as is.

Odonno · 2017-11-10T15:03:00Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json

+      {
+        "Name": "HeaderedContentControl",
+        "Type": "HeaderedContentControlPage",
+        "About": "",


Missing description?

Odonno · 2017-11-10T15:03:46Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json

+      {
+        "Name": "HeaderedItemsControl",
+        "Type": "HeaderedItemsControlPage",
+        "About": "",


Missing description?

Odonno · 2017-11-10T15:52:37Z

docs/controls/HeaderedContentControl.md

+The `Header` property can be set to a string, or any xaml elements. If binding the `Header` to an object that is not a string, use the `HeaderTemplate` to control how the content is rendered.
+```xaml
+<controls:HeaderedControlControl Header="This is the header!"/>
+


Shouldn't we split into 2 code blocks?

Odonno · 2017-11-10T16:44:18Z

There is a conflict with the master branch.

# Conflicts: # Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

skendrot · 2017-11-10T16:58:33Z

It didn't yesterday! 😝

windowstoolkitbot · 2017-11-10T18:37:42Z

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #995

Nirmal4G · 2021-03-06T16:03:50Z

Related: #3710 (Missing metadata for the DesignTime in VS IDE)

skendrot added 16 commits July 13, 2017 07:09

Addition of HeaderedContentControl and HeaderedItemsControl

d15b8a1

Merge master info HeaderedControls

d8a1e2b

stub out sample pages

b3c9588

Add the default theme to the control and project

05a6fc7

Add summary tag for items control

b5ab117

Add some sample page stuff

6d06336

change shallow copy control

32c7fb7

add (c) header

47afe50

Complete items sample page

1becd27

Merge branch 'master' into HeaderedControls

c0219c6

move system namespace to the top

3a35ad1

Remove border to match style of ItemsControl which also does not resp…

460986c

…ect Border properties

Match Horizontal and VerticalContentAlignment with a regular ContentC…

f8907a2

…ontrol

sample for HeaderedContentControl

1e40cba

Add sample images

546be9c

Merge branch 'master' into HeaderedControls

6a5da01

skendrot changed the title ~~Headered controls~~ [WIP] Headered controls Nov 7, 2017

skendrot added the need documentation 📃 label Nov 7, 2017

skendrot changed the title ~~[WIP] Headered controls~~ Headered controls Nov 7, 2017

nmetulev reviewed Nov 7, 2017

View reviewed changes

nmetulev added this to the v2.1 milestone Nov 7, 2017

Make sure we call the OnHeaderChanged method

15f7650

nmetulev added the controls 🎛️ label Nov 7, 2017

skendrot added 2 commits November 9, 2017 17:03

Add documentation for the HeaderedControlControl

97e2279

Add documentation for the HeaderedItemsControl

5631061

Odonno reviewed Nov 10, 2017

View reviewed changes

skendrot added 3 commits November 10, 2017 09:12

Fix copy/paste typo

be0662a

Break up xaml sample into two samples

0ec03fd

fix keyword

2e4a4ea

Add about blurbs

f67c70c

Merge branch 'master' into HeaderedControls

f6c45cf

# Conflicts: # Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

nmetulev approved these changes Nov 10, 2017

View reviewed changes

Odonno approved these changes Nov 10, 2017

View reviewed changes

Odonno merged commit 9f66cdd into CommunityToolkit:master Nov 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Headered controls #1599

Headered controls #1599

skendrot commented Nov 7, 2017 •

edited

Loading

nmetulev Nov 7, 2017

skendrot Nov 7, 2017

skendrot Nov 7, 2017

nmetulev Nov 7, 2017

skendrot Nov 7, 2017

nmetulev Nov 7, 2017

skendrot Nov 7, 2017

nmetulev Nov 7, 2017

skendrot Nov 7, 2017

nmetulev commented Nov 7, 2017

Odonno left a comment

Odonno Nov 10, 2017

Odonno Nov 10, 2017

Odonno Nov 10, 2017

Odonno commented Nov 10, 2017

skendrot commented Nov 10, 2017 •

edited

Loading

windowstoolkitbot commented Nov 10, 2017

Nirmal4G commented Mar 6, 2021

Headered controls #1599

Headered controls #1599

Conversation

skendrot commented Nov 7, 2017 • edited Loading

PR Type

What is the current behavior?

PR Checklist

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmetulev commented Nov 7, 2017

Odonno left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Odonno commented Nov 10, 2017

skendrot commented Nov 10, 2017 • edited Loading

windowstoolkitbot commented Nov 10, 2017

Nirmal4G commented Mar 6, 2021

skendrot commented Nov 7, 2017 •

edited

Loading

skendrot commented Nov 10, 2017 •

edited

Loading