Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MenuItem to inherit from HeaderedItemsControl #1616

Merged
merged 3 commits into from
Nov 15, 2017

Conversation

skendrot
Copy link
Contributor

PR Type

What kind of change does this PR introduce?
Change MenuItem to inherit from HeaderedItemsControl instead of ItemsControl. Remove the Header and HeaderTemplate properties from MenuItem

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[x] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

MenuItem inherits from ItemsControl and has a local Header and HeaderTemplate property

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

MenuItem now inherits from HeaderedItemsControl and takes advantage of it's Header and HeaderTemplate properties

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@skendrot
Copy link
Contributor Author

I did not change the docs for this because it notes a special behavior when using the Header property.

@nmetulev nmetulev merged commit f38fd02 into CommunityToolkit:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants