Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollHeader and Behaviors tweak #1669

Merged
merged 1 commit into from
Nov 29, 2017
Merged

ScrollHeader and Behaviors tweak #1669

merged 1 commit into from
Nov 29, 2017

Conversation

hermitdave
Copy link
Contributor

Issue: #1659

PR Type

What kind of change does this PR introduce?
ScrollHeader and Behaviors tweak

[] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[x] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[x] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

ScrollHeader requires TargetListView to be set. It should not be mandatory as ScrollHeader is set to ListView / GridView header.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

Make TargetListViewBase in ScrollHeader optional
Mark TargetListViewBase as obsolete
Tweak FadeHeaderBehavior, QuickReturnHeaderBehavior and StickyHeaderBehavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Make TargetListViewBase in ScrollHeader optional
Mark TargetListViewBase as obsolete
Tweak FadeHeaderBehavior, QuickReturnHeaderBehavior and StickyHeaderBehavior
@hermitdave hermitdave requested a review from nmetulev November 29, 2017 11:15
@hermitdave
Copy link
Contributor Author

@pdehne any thoughts on this?

@pdehne
Copy link
Contributor

pdehne commented Nov 29, 2017

Looks good! Getting rid of the TargetListViewBase property makes it definetely easier to use.

@hermitdave hermitdave closed this Nov 29, 2017
@hermitdave hermitdave deleted the HD-ScrollHeader branch November 29, 2017 15:12
@hermitdave hermitdave restored the HD-ScrollHeader branch November 29, 2017 15:14
@hermitdave hermitdave reopened this Nov 29, 2017
@hermitdave hermitdave merged commit b8ceff1 into master Nov 29, 2017
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1659

@hermitdave hermitdave deleted the HD-ScrollHeader branch November 29, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants