NetworkHelper updates to fix crashes logged #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UpdateConnectionInformation method to NetworkHelper Add try catch to UpdateConnectionInformation Lock NetworkHelper.ConnectionInformation before calling update. Add Reset method to ConnectionInformation Tweaks to ConnectionInformation.UpdateConnectionInformation method
hermitdave
changed the title
hermitdave
changed the title
nmetulev
reviewed
Dec 6, 2017
| @@ -30,22 +30,20 @@ public class ConnectionInformation | |||
| /// Updates the current object based on profile passed. | |||
| /// </summary> | |||
| /// <param name="profile">instance of <see cref="ConnectionProfile"/></param> | |||
| public virtual void UpdateConnectionInformation(ConnectionProfile profile) | |||
| public void UpdateConnectionInformation(ConnectionProfile profile) | |||
There was a problem hiding this comment.
Would this be considered a breaking change?
There was a problem hiding this comment.
I consider that method as not being sufficient for anyone to override.
How and why it was marked virtual is a mystery to me.
For anyone insane enough to inherit from connection information object yes it's a bragging change though I'm at loss as to why one would.
There was a problem hiding this comment.
So it sound like this is fixing a bug then instead ;)
Approved
nmetulev
approved these changes
Dec 6, 2017
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1645
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There are no exception handlers and passing null when initialising the NetworkHelper isn't ideal.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Add UpdateConnectionInformation method to NetworkHelper
Add try catch to UpdateConnectionInformation
Lock NetworkHelper.ConnectionInformation before calling update.
Add Reset method to ConnectionInformation
Tweaks to ConnectionInformation.UpdateConnectionInformation method
Does this PR introduce a breaking change?
Other information