Notifications - added System.Xml.ReaderWriter 4.3.0 as reference #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odonno
approved these changes
Dec 12, 2017
|
@nmetulev So, we will merge it into master but you plan to release a minor update so devs can have the fix, right? |
|
Correct, I will cherry pick into rel/2.1.1 |
andrewleader
approved these changes
Dec 12, 2017
|
@nmetulev, I tested with the generated nuget package, it worked! Thanks! |
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1676
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Notifications library does not throw an exception
Does this PR introduce a breaking change?