#1673 Adding a Color property to Light #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odonno
reviewed
Dec 13, 2017
| /// <returns>An animation set.</returns> | ||
| public static AnimationSet Light( | ||
| this FrameworkElement associatedObject, | ||
| double distance = 0d, | ||
| double duration = 500d, | ||
| double delay = 0d) | ||
| double delay = 0d, | ||
| Color color = default(Color)) |
There was a problem hiding this comment.
By default, shouldn't it be Colors.White instead of Black?
There was a problem hiding this comment.
good spot, I changed the type to be nullable, so if it detects null it will change it to White. You can't set the Color object as a default parameter as it needs to be a compile time constant.
nmetulev
approved these changes
Dec 20, 2017
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
#1673
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Defaults to white
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
A new Color property which allows you to change the color of the light.
Does this PR introduce a breaking change?
Other information