Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to tweets with 280 characters #1723

Merged
merged 5 commits into from
Feb 13, 2018
Merged

Added support to tweets with 280 characters #1723

merged 5 commits into from
Feb 13, 2018

Conversation

pepeizq
Copy link
Contributor

@pepeizq pepeizq commented Dec 26, 2017 •
edited
Loading

Issue: #

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[ ] Other... Please describe:

What is the current behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added / updated (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@dnfclas
Copy link

dnfclas commented Dec 26, 2017 •
edited
Loading

CLA assistant check
All CLA requirements met.

@pepeizq pepeizq changed the title Patch 1 Added support to tweets with 280 characters Dec 26, 2017
@nmetulev nmetulev requested a review from cbarkerms January 2, 2018 22:21
@nmetulev
Copy link
Contributor

nmetulev commented Jan 2, 2018

ping @cbarkerms for his review

michael-hawker
michael-hawker reviewed Jan 9, 2018
View reviewed changes
Microsoft.Toolkit.Uwp.Services/Services/Twitter/TwitterExtended.cs
namespace Microsoft.Toolkit.Uwp.Services.Twitter
{
/// <summary>
/// Twitter User type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link to the API docs we can put here which has info on the JSON format/service info?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @pepeizq

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.twitter.com/en/docs/tweets/tweet-updates

@nmetulev nmetulev added this to the v2.2 milestone Jan 19, 2018
@nmetulev
Copy link
Contributor

@pepeizq Up?

@cbarkerms cbarkerms merged commit ab3ca87 into CommunityToolkit:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker left review comments

@nmetulev nmetulev nmetulev approved these changes

@cbarkerms cbarkerms Awaiting requested review from cbarkerms

Assignees
No one assigned
Labels
services 👷‍♂️
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@pepeizq @dnfclas @nmetulev @cbarkerms @michael-hawker