Anbare/toast additions 1801 #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently testing this in actual projects with the generated Nuget packages |
added 2 commits
January 22, 2018 10:31
FileNotFoundException was being thrown since System.Xml.ReaderWriter assembly couldn't be loaded. Same issue was fixed in the C#/C++ version previously, simply had to reference that package.
This reverts commit c15aa34.
|
This is ready for review, tested the new features in a new C# app using the NuGet package from build artifacts, all good! |
nmetulev
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
New toast features for My People shoulder tap and upcoming toast telemetry dashboard.
What is the current behavior?
These properties don't exist.
PR Checklist
Please check if your PR fulfills the following requirements:
Tested using the NuGet package from build artifacts in a new C# project
The official UWP docs will be updated after the package is live
The official code sample for My People shoulder tap will be updated after the package is live
What is the new behavior?
Adding new properties so you can send My People shoulder taps and include identifiers for telemetry.
Does this PR introduce a breaking change?
Other information