-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename extensions with the Extensions suffix (deprecated old, added new) #1765
Conversation
Looks like some files were removed and added vs. moved with git mv? Or is it just GitHub not showing it? Also, it could be useful to preserve the history for the new copies, but that involves more work (from Robert's answer here):
|
Shouldn't this be part of the 3.0 release? |
@michael-hawker, you absolutely correct. There are two files that git didn't pick up as moved (and I didn't use git mv). It's the HyperlinkExtensions and ListViewExtensions docs. @skendrot, this work is to prepare for removing the deprecated extensions in 3.0. I deprecated the existing extensions (but not removed) and created copies with the new name. |
Well that's what happens when you speak without actually looking at the diff!! |
I assume ImageEx stays the same as it's not an extension of image? |
@michael-hawker, correct, it's a control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a single question on the unwiring of an event. Otherwise it looks good.
|
||
if (e.NewValue is string normalizedValue) | ||
{ | ||
element.SizeChanged -= KeepCenteredElementSizeChanged; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have already done this on line 606. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1561 |
Issue: #1561
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
The following extensions have been renamed
Does this PR introduce a breaking change?