AdaptiveGridView fix when HorizontalAlignment is not stretch #1787
Conversation
…event to endlessly fire when the HorizontalAlignment is Center because the width is continually shrinking.
| @@ -233,7 +233,7 @@ private void RecalculateLayout(double containerWidth) | |||
| if (containerWidth > 0) | |||
| { | |||
| var newWidth = CalculateItemWidth(containerWidth); | |||
| ItemWidth = Math.Floor(newWidth - 1); | |||
| ItemWidth = Math.Floor(newWidth); | |||
There was a problem hiding this comment.
Was this trying to prevent overlap or something? Do we need to adjust the left value of the next item?
There was a problem hiding this comment.
@nmetulev Any reason you had the -1 in there?
There was a problem hiding this comment.
We don't do any layout with this control. We just set the height and width of the GridViewItem controls through binding to ItemHeight and ItemWidth
| @@ -233,7 +233,7 @@ private void RecalculateLayout(double containerWidth) | |||
| if (containerWidth > 0) | |||
| { | |||
| var newWidth = CalculateItemWidth(containerWidth); | |||
| ItemWidth = Math.Floor(newWidth - 1); | |||
| ItemWidth = Math.Floor(newWidth); | |||
There was a problem hiding this comment.
Another issue with scrollbars. Before:
After, the collapsible scrollbar is less noticeable as its margin isn't clear:
Thoughts?
There was a problem hiding this comment.
That's standard for lists in which the items span the entire width. Here's a standard GridView with similar settings
There was a problem hiding this comment.
Good to know, I hadn't been paying as much attention to the overlap until this set of changes. :)
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1737 |
Issue: #1737
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Application will crash when HorizontalAlignment is set to anything but stretch
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Do not subtract one from the new width. This causes the SizeChanged event to endlessly fire when the HorizontalAlignment is not Stretch because the width is continually shrinking.
Does this PR introduce a breaking change?
Other information
Related to and caused by #1552