Fix layout when Margin of GridViewItem is not zero #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th to allow for proper placement when the user has specified a Margin that is different
…izontal and Vertical Content alignment in PrepareContainerForItemOverride
nmetulev
approved these changes
Feb 13, 2018
michael-hawker
approved these changes
Feb 13, 2018
| style.Setters.Add(new Setter(HorizontalContentAlignmentProperty, HorizontalAlignment.Stretch)); | ||
| style.Setters.Add(new Setter(VerticalContentAlignmentProperty, VerticalAlignment.Stretch)); | ||
| style.Setters.Add(new Setter(MarginProperty, new Thickness(0, 0, 0, 4))); | ||
| style.Setters.Add(new Setter(PaddingProperty, new Thickness(2, 0, 2, 0))); |
There was a problem hiding this comment.
The DefaultItemMargin below was 0,0,4,4, should it be updated to be 2,0,2,4 to match this or was that intentional?
If it's intentional that's fine, I think the buffer at the right/bottom is better than the split, but just wanted to make sure.
There was a problem hiding this comment.
The default margin for an item is 0,0,4,4. The default padding is 0. I think @nmetulev changed to this to help with knowing the width of the item
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1739
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If you define an ItemContainerStyle for the AdaptiveGridView and do not define a Margin, or if the Margin is different from what is defined by the AdaptiveGridView then items will not span the entire width of the control.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
You can now define an ItemContainerStyle that does not define a Margin or a Margin different from the default and items will still layout properly
Does this PR introduce a breaking change?
Other information
NOTE: This change has an added benefit that the AdaptiveGridView can now take advantage of an implicit style defined for a GridViewItem. This change removes the hard coded ItemContainerStyle which was preventing implicit styles to be used.