Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated AppPinManager #1825

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Deprecated AppPinManager #1825

merged 2 commits into from
Feb 21, 2018

Conversation

nmetulev
Copy link
Contributor

Issue: #1811

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the new behavior?

Per a request from the app model team, the AppPinManager will be deprecated and throw a warning to use the platform APIs. The AppPinManager sample has also been removed from the sample app

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes

Other information

@azchohfi azchohfi self-requested a review February 20, 2018 23:30
@azchohfi
Copy link
Contributor

azchohfi commented Feb 20, 2018

@IbraheemOsama Please, just fix the merge conflict and we should be fine.

@nmetulev nmetulev merged commit 2bad32a into master Feb 21, 2018
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1811

@nmetulev nmetulev deleted the nmetulev/apppinmanager branch April 27, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants