Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu focus on press on textbox #1829

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

IbraheemOsama
Copy link
Member

Issue: #1822

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

This PR solves issue produced when menu is used with a textbox or textarea

What is the new behavior?

When press any Alt+ anycharacter not registered the focus says on the main control and doesn't go to the menu

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X ] Tested code with current supported SDKs
  • [ X] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes

Other information

@IbraheemOsama IbraheemOsama changed the title Menu focus on press Menu focus on press on textbox Feb 19, 2018
@nmetulev nmetulev added this to the v2.2 milestone Feb 19, 2018
@azchohfi azchohfi self-requested a review February 20, 2018 23:24
@azchohfi azchohfi merged commit f66fb80 into CommunityToolkit:master Feb 20, 2018
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants