Adding the Surface Dial Textbox Helper class. #704
Conversation
|
Hi @petriw, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@petriw, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| @@ -0,0 +1,45 @@ | |||
| <Page | |||
There was a problem hiding this comment.
Could you please run xaml styler over this file please (https://visualstudiogallery.msdn.microsoft.com/3de2a3c6-def5-42c4-924d-cc13a29ff5b7)
There was a problem hiding this comment.
Means you'll need to update the xaml in the bind file too.
| { | ||
| public SurfaceDialTextboxHelperPage() | ||
| { | ||
| this.InitializeComponent(); |
There was a problem hiding this comment.
Remove usages of "this."
| @@ -0,0 +1 @@ | |||
| # SurfaceDialTextboxHelper Control | |||
There was a problem hiding this comment.
Is this missing more content?
|
Nothing more than what @ScottIsAFool mentioned :) |
…d made modifications to the bind code to reflect these changes. Removed the template generated this. in SamplePages/SurfaceDialTextboxHelper/SurfaceDialTextboxHelperPage.xaml.cs. Added the documentation for the control in controls/SurfaceDialTextboxHelper.md
|
What happen is I used it on a TH2 app? Does it crash or just failed silently? |
| /// <summary> | ||
| /// If you provide the Controller yourself, set this to true so you won't add new menu items. | ||
| /// </summary> | ||
| public static readonly DependencyProperty ForceMenuItemProperty = |
There was a problem hiding this comment.
can you move all DP at the beginning of the file (my bad I forgot to mention it earlier)
|
Sounds good to me. |
A new helper control using attached properties to add Surface Dial capabilities to a Textbox.