fixed pulltorefreshlistview refresh with mouse re: #647 #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why forcing the mouse support to off by default? |
|
I can put it back to enabled by default if people believe it's important, but I feel the feature is not required by most scenarios as it's not something users are used to doing with mouse. |
|
makes sense. Let's keep it off by default |
deltakosh
approved these changes
Jan 12, 2017
|
Does this PR fixes #749? |
|
yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #647
BREAKING CHANGE: changed default behavior to be false for mouse
disabled mouse interaction when mouse is over scrollbar to prevent content scrolling in both directions
disabled mouse interaction if scrollviwer is not already on top to prevent unintended refreshing and fix issue with grouping