Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ItemContainerStyleSelector to the MasterDetailsView ListView #1902

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

mashedkeyboard
Copy link
Contributor

ItemContainerStyleSelector allows for code to change the ItemContainerStyle on the fly

Issue: #1901

PR Type

What kind of change does this PR introduce?

  • Bugfix (see issue)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [n/a] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [n/a] Sample in sample app has been added / updated (for bug fixes / features)
  • [n/a] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes

ItemContainerStyleSelector allows for code to change the ItemContainerStyle on the fly
@mashedkeyboard mashedkeyboard changed the title Added ItemContainerStyleSelector Added ItemContainerStyleSelector to the MasterDetailsView ListView Mar 17, 2018
Copy link
Contributor

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'd like @skendrot to take a look at this as well.

@skendrot skendrot merged commit 6ed5e41 into CommunityToolkit:master Mar 20, 2018
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1901

@mashedkeyboard mashedkeyboard deleted the patch-1 branch March 20, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants