Infinite canvas #1958

IbraheemOsama · 2018-04-08T12:52:51Z

Issue: #1572

PR Type

What kind of change does this PR introduce?
Infinite Canvas #1572

Feature

What is the current behavior?

What is the new behavior?

Infinite Canvas

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Docs have been added/updated which fit documentation template. (for bug fixes / features)
Sample in sample app has been added / updated (for bug fixes / features)
- Icon has been created (if new sample) following the Thumbnail Style Guide and templates
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes

Other information

…initeCanvas

michael-hawker · 2018-04-24T06:34:48Z

Here's the UWP OneNote text color for reference:

The 'A' isn't as narrow and it has the bigger block of color underneath it for the current color selection.

I don't know if we have to go so far as swapping out the entire color picker, but I think it can be tweaked for black to still show the color somehow, no?

For the other comment, there were two pieces:

'Touck Inking' typo in toolbar
This was what it looked like before I saved (using pencil):

And after loading (its ballpoint pen):

IbraheemOsama · 2018-04-30T14:00:47Z

@nmetulev @michael-hawker ping.
For enabling touch Ink in case pen is not supported I couldn't find an API (I didn't dig deep) but when I opened edge it was selected by default as well and I don't think I used it before.
I have another issue when click the bold/italic buttons the styles of the button doesn't work well with the theme !! should I restyle the whole toggleButton or maybe you have a workaround.

michael-hawker · 2018-05-02T16:03:17Z

Some new issues I found:

Was editing a textbox and then hit erase all but the textbox outline still remained:

I couldn't type until I clicked elsewhere. Probably should remove the current box and wait for the user to click and interact again.

If I tab away from the font-size box, then I get a weird cursor artifact on the right:

If I type letters in the font-size and then tab away, they get erased, but the current font-size isn't restored as the value.
@WilliamABradley guess I need to make a feature request for the Text Toolbar to support a drop-down menu style, eh?

Is there a way for the selected text to be readible still, it's just a big block currently:

The cursor/dimensions are still off when making something bold (see above selection) until the box is deselected and interacted with again:

IbraheemOsama · 2018-05-03T01:14:09Z

@michael-hawker thanks for your valuable input :) I will work on the issue except number 5 because it's a limitation in the textBox as you can't change the opacity of the selected text but you can change the color.

…initeCanvas

IbraheemOsama · 2018-05-11T01:43:19Z

@michael-hawker @nmetulev ping.

nmetulev · 2018-05-13T21:09:04Z

The only thing I noticed is that typing letters in the font-size is allowed and they don't get removed. I'd expect the previously good text size to be restored as soon as I type away. Or only allow digits to be entered.

I recommend you get the documentation and icon finished as soon as possible to give us time to review.

Other than that, looks awesome.

IbraheemOsama · 2018-05-18T12:36:02Z

@nmetulev @michael-hawker ping

nmetulev

Awesome

nmetulev · 2018-05-18T16:36:08Z

docs/controls/InfiniteCanvas.md

+
+## Examples
+
+The following sample demonstrates how to add Grid Splitter Control


Typo - should be InfiniteCanvas control

Vijay-Nirmal · 2018-05-18T16:43:43Z

docs/controls/InfiniteCanvas.md

+<Page ...
+     xmlns:controls="using:Microsoft.Toolkit.Uwp.UI.Controls"/>
+
+<controls:InfiniteCanvas Name="canvas"/>


Add some Properties and Events in this syntax. This look .....

The default usage for the canvas is "no properties" that's why it is better this way :)

IbraheemOsama · 2018-05-21T23:53:59Z

@michael-hawker ping :)

michael-hawker

One small comment on the default color, then I'm good.

michael-hawker · 2018-05-22T23:00:00Z

Microsoft.Toolkit.Uwp.UI.Controls/InfiniteCanvas/InfiniteCanvas.xaml

+                                        <Button.Flyout>
+                                            <Flyout Placement="Bottom">
+                                                <ColorPicker x:Name="CanvasTextBoxColorPicker"
+                                                             Color="Red" />


Thought this was just for the sample app, not sure if we want Red text to be the default for all text on a default InifiniteCanvas.

Probably just best to set it back to black. This is more an issue I have with the ColorPicker control itself. I may file some feedback hub issues on it.

Yeah but the black color picker is really misleading. I think i will create a property so the user can change the default color :)
lets leave it at developer's side 😈

IbraheemOsama added 30 commits March 29, 2018 16:28

Adding infinite canvas initial commit

c21f3bb

Merge remote-tracking branch 'refs/remotes/Microsoft/master' into Inf…

4ba9f47

…initeCanvas

Editing samples.json

6c81f9f

Infinite Canvas Integrated and no build errors

7d1984e

Adding drwabeList

75a1f8d

Adding resize events

ff38584

Adding erase first step

cf69a6e

Fixing bounding rect problem

eaafe34

adding clear all

5c04d5d

adding custom text button

c47e4ff

addign text box click functionality

32d64ac

Text working with inking

743c99c

Fixing textbox issues

919bd55

Adding extract text basic logic

914fdbf

Infinite canvas finally working with virtualization

afc9cf4

Adding canvas Text Drawable.

55748f8

Everything is working start to remove the textbox

090ecb6

Removing margin

414e83f

Removing text border

324550b

refactoring

9f32997

Adding transparent textbox

06ebb05

Text is working fine but in case of mouse only need to handle pan

3b46c14

Now text is working fine :)

0001962

Adding reverse process for text and it is working

26aa07a

Tring to fix textbox right navigation problem

e65538c

Everything is working after disableing interaction

de9ed80

Adding button bold and italic

0a5c040

Hahahaha TextBox With Scroll you loose

4b7fdb0

Fixing scaling issue

edb8bb8

Ink Drawing matches the canvas

c1b5cbe

IbraheemOsama added 4 commits April 30, 2018 22:36

addign do redo fixing execption

d5b73db

Adding styles

9209c9e

Merging from master

a4ad3f8

Making color red

5fa9b22

IbraheemOsama added 3 commits May 11, 2018 09:26

Fixing PR Comments

34733e9

Fixing theming issue

27b954c

Merge remote-tracking branch 'refs/remotes/Microsoft/master' into Inf…

3ebe1cd

…initeCanvas

IbraheemOsama added 4 commits May 18, 2018 18:42

Adding number only textbox

2e84e1b

Adding Icon

a16634a

Adding control documenations

c5074b6

Merge branch 'master' into InfiniteCanvas

f57fbd4

IbraheemOsama removed the need documentation 📃 label May 18, 2018

nmetulev approved these changes May 18, 2018

View reviewed changes

Vijay-Nirmal reviewed May 18, 2018

View reviewed changes

azchohfi and others added 3 commits May 18, 2018 10:57

Merge branch 'master' into InfiniteCanvas

8a69256

Fixing typo

db3b096

Merging from master

aee31d8

Merge branch 'master' into InfiniteCanvas

4df09aa

azchohfi self-requested a review May 22, 2018 22:29

michael-hawker approved these changes May 22, 2018

View reviewed changes

Merge branch 'master' into InfiniteCanvas

7a00d8f

azchohfi merged commit 3dc89b9 into CommunityToolkit:master May 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infinite canvas #1958

Infinite canvas #1958

IbraheemOsama commented Apr 8, 2018 •

edited by nmetulev

Loading

michael-hawker commented Apr 24, 2018

IbraheemOsama commented Apr 30, 2018

michael-hawker commented May 2, 2018

IbraheemOsama commented May 3, 2018

IbraheemOsama commented May 11, 2018

nmetulev commented May 13, 2018

IbraheemOsama commented May 18, 2018

nmetulev left a comment

nmetulev May 18, 2018

Vijay-Nirmal May 18, 2018

IbraheemOsama May 18, 2018

IbraheemOsama commented May 21, 2018

michael-hawker left a comment

michael-hawker May 22, 2018

IbraheemOsama May 22, 2018


		## Examples

		The following sample demonstrates how to add Grid Splitter Control

Infinite canvas #1958

Infinite canvas #1958

Conversation

IbraheemOsama commented Apr 8, 2018 • edited by nmetulev Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

michael-hawker commented Apr 24, 2018

IbraheemOsama commented Apr 30, 2018

michael-hawker commented May 2, 2018

IbraheemOsama commented May 3, 2018

IbraheemOsama commented May 11, 2018

nmetulev commented May 13, 2018

IbraheemOsama commented May 18, 2018

nmetulev left a comment

Choose a reason for hiding this comment

nmetulev May 18, 2018

Choose a reason for hiding this comment

Vijay-Nirmal May 18, 2018

Choose a reason for hiding this comment

IbraheemOsama May 18, 2018

Choose a reason for hiding this comment

IbraheemOsama commented May 21, 2018

michael-hawker left a comment

Choose a reason for hiding this comment

michael-hawker May 22, 2018

Choose a reason for hiding this comment

IbraheemOsama May 22, 2018

Choose a reason for hiding this comment

IbraheemOsama commented Apr 8, 2018 •

edited by nmetulev

Loading