MarkdownTextBlock - Resize image when overflow and Added ImageMaxWidth and ImageMaxHeight property #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @WilliamABradley for review |
|
This PR seems inactive. @Vijay-Nirmal Do you need help to complete this issue? |
|
Waiting for review :) |
|
I'll take a look when I have time |
WilliamABradley
approved these changes
May 5, 2018
michael-hawker
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1882
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the image is bigger than the control then it will overflow and there is no way of seeing the overflown part.
What is the new behavior?
The image should resize when it overflows like in docs.microsoft.com
PR Checklist
Please check if your PR fulfills the following requirements: