Camera helper WIP #1980

skommireddi · 2018-04-16T23:03:35Z

Issue: #

PR Type

What kind of change does this PR introduce?
Feature
Documentation content changes
Sample app changes

What is the current behavior?

What is the new behavior?

Added a new CameraHelper to the Toolkit Helpers
Added a sample page and docs to show the usage of Camera Helper
Added a CameraPreview XAML control to preview video from camera sources
Added a sample page and docs for CameraPreview Control

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current [Fall Creators Update (16299)]
Docs have been added/updated which fit documentation template. (for bug fixes / features)
Sample in sample app has been added / updated (for bug fixes / features)
- Icon has been created (if new sample) following the Thumbnail Style Guide and templates
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes

Other information

…ing a sample page to select frame sources

- Styling for sample page - Get software bitmap and hook it to the Image element - Added placeholder documentation CamerHelper.md - Added camera icon for helper

…Initialization and any error messages. - Updated xaml to show error messages.

…a helper initialization - Updated xaml sample page to hide preview controls etc when no sources are found - fixing clean up resources exception when navigating away from page and no resources are found.

Merge from original

dnfclas · 2018-04-16T23:03:46Z

All CLA requirements met.

michael-hawker · 2018-04-16T23:25:30Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelper.cs

+using Windows.Media.Capture.Frames;
+using Windows.Media.MediaProperties;
+
+namespace Microsoft.Toolkit.Uwp.Helpers.CameraHelper


namespace should just be Microsoft.Toolkit.Uwp.Helpers

Agree, remove CameraHelper from namespace

michael-hawker · 2018-04-16T23:27:42Z

docs/helpers/CameraHelper.md

+## Example
+
+```csharp
+todo- provide example


michael-hawker · 2018-04-16T23:28:00Z

docs/helpers/CameraHelper.md

+| [Device family](http://go.microsoft.com/fwlink/p/?LinkID=526370) | Universal, 10.0.14393.0 or higher |
+| --- | --- |
+| Namespace | Microsoft.Toolkit.Uwp |
+


Add Nuget package link

what nuget package link?

michael-hawker · 2018-04-16T23:30:28Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelper.cs

+                _frameReader = await _mediaCapture.CreateFrameReaderAsync(_frameSource);
+                _frameReader.AcquisitionMode = MediaFrameReaderAcquisitionMode.Realtime;
+                _frameReader.FrameArrived += Reader_FrameArrived;
+                Debug.WriteLine($"Frame Reader created on source: {_frameSource.Info.Id}");


We should remove the debug write lines.

JohnnyWestlake · 2018-04-17T08:53:27Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelper.cs

+        /// Initializes Media Capture settings and starts video capture using Frame Reader.
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns>
+        public async Task<CameraHelperResult> InitializeAndStartCapture(MediaFrameSourceGroup group)


Can these async methods have Async at the end of their names?

JohnnyWestlake · 2018-04-17T08:54:34Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelper.cs

+        /// Clean up and dispose resources
+        /// </summary>
+        /// <returns>>A <see cref="Task"/> representing the asynchronous operation.></returns>
+        public async Task Cleanup()


Can these async methods have Async at the end of their names?

JohnnyWestlake · 2018-04-17T08:54:49Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/FrameSourceGroupsHelper.cs

+        /// Returns first available Frame Source Group.
+        /// </summary>
+        /// <returns>>A MediaFrameSourceGroup<see cref="Task"/> representing the asynchronous operation.</returns>
+        public static async Task<MediaFrameSourceGroup> GetFirstAvailableFrameSourceGroup()


Can these async methods have Async at the end of their names?

Odonno · 2018-04-18T13:21:30Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelperResult.cs

+        /// <summary>
+        /// Gets or sets message indicating information when camera helper initialization is not successful
+        /// </summary>
+        public string Message { get => message; set => message = value; }


Why not a simple AutoProperty with default value?

Sure. Changed it to auto-property with default value.

Refactored sample page to use the xaml control Updated styling

…w Control Added doc for Camera Helper class, updated code bind file and sample page

Merge from original to update fork with latest

# Conflicts: # Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

LPBourret · 2018-04-22T16:21:45Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraHelper/CameraHelperCode.bind

+  if(result.Status == false)
+  {
+	// log the error
+	var errorMessage = result.Message;


no logging actually happening here

Meant as an informational message, will reword it.

LPBourret · 2018-04-22T16:23:54Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelperResult.cs

+        /// <summary>
+        /// Gets or sets a value indicating whether camera helper initialization was successful or not
+        /// </summary>
+        public bool Status { get; set; }


rename to something more indicative i.e. isInitialized

Or an Enum if there is more than two, and potentialy removing the Message property below

I used message property so we could pass on the exception info to the user. I can make an enum and pass on the initialization error messages.

LPBourret · 2018-04-22T16:30:57Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraHelper/CameraHelperCode.bind

+  }
+
+  // Subscribe to the video frame as they arrive
+  cameraHelper.VideoFrameArrived += CameraHelper_VideoFrameArrived;


do you want to hook a callback to this event if initialization failed?

If initialization failed, you wont get any frames.

precisely, this is why I am asking and implicitly suggesting to not hook a callback unless initialization succeeds

LPBourret · 2018-04-22T16:32:28Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraHelper/CameraHelperCode.bind

+  // No frame source available.
+}
+
+private void CameraHelper_VideoFrameArrived(object sender, VideoFrameEventArgs e)


what does this method do?

This is a way for user to get video frames after they select a camera source. The user can subscribe to CameraHelper VideoFrameArrived event to get frames in real time. This just shows example code of how they can get frames from the event args.

can you add comments in the body of the method to that effect (i.e. this is where code to handle the video frame lives)

LPBourret · 2018-04-22T16:37:29Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/VideoFrameEventArgs.cs

+    {
+        /// <summary>
+        /// Gets or sets Video Frame</summary>
+        public VideoFrame VideoFrame { get; set; }


may want to only expose a getter and make the setter private or internal for usage only by CameraHelper

Yup, that's a good suggestion, will change setter to internal

LPBourret · 2018-04-22T16:52:54Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelper.cs

+        /// <summary>
+        /// Initializes a new instance of the <see cref="CameraHelper"/> class.
+        /// </summary>
+        public CameraHelper()


since this does nothing, you could get rid of it and use a factory pattern to create and initialize asynchronously your CameraHelper instance instead

LPBourret · 2018-04-22T17:00:41Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraHelper/CameraHelperPage.xaml

+        </ComboBox>
+        <TextBlock x:Name="CameraErrorTextBlock" Style="{StaticResource MessageStyle}"  Margin="0,0,0,10" Visibility="Collapsed"></TextBlock>
+        <Button x:Name="CaptureButton" Content="Capture Video Frame" Margin="0,10" Click="CaptureButton_Click"></Button>
+        <Image x:Name="CurrentFrameImage" MinWidth="300" Width="400" HorizontalAlignment="Left"></Image>


instead of using an Image, you can use a MediaPlayerElement XAML control and hook it to your source directly (like in my email) so you don't have to orchestrate rendering of the frames as they come in

this would save you most of the code in your page below

This is just a different example of using the Video Frames and displaying in an image using the Camera Helper directly. The CameraPreview sample page demonstrates what you mentioned and it uses the xaml control encapsulating the MediaPlayerElement. Does that make sense?

LPBourret · 2018-04-22T17:06:49Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraPreview/CameraPreviewPage.xaml

+                                     VideoFrameArrived="CameraPreviewControl_VideoFrameArrived"
+                                     SoftwareBitmapArrived="CameraPreviewControl_SoftwareBitmapArrived"></controls:CameraPreview>
+        <TextBlock x:Name="ImageHeader" Text="Image" ></TextBlock>
+        <Image x:Name="CurrentFrameImage" MinWidth="300" Width="400" HorizontalAlignment="Left"></Image>


isn't the goal of CameraPreview to preview the stream? why is there an image control as well in this page then?

I wanted to show WinML usage example. The goal is to show how the user can subscribe and get video frames.

LPBourret · 2018-04-22T17:23:20Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

+
+                _videoPreviewErrorTextBlock.Text = result.Message;
+                _videoPreviewErrorTextBlock.Visibility = result.Status ? Visibility.Collapsed : Visibility.Visible;
+                _videoPreviewText.Visibility = !result.Status ? Visibility.Collapsed : Visibility.Visible;


nit: instead of checking if(!result.Status == true), don't negate result.Status and invert your logic

LPBourret · 2018-04-22T17:27:40Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

+        /// <summary>
+        /// Event raised when a new software bitmap arrives.
+        /// </summary>
+        public event EventHandler<SoftwareBitmap> SoftwareBitmapArrived;


as said previously, I would get rid of this one and keep only the other one

Agree, there should be one event

this would mean I would return VideoMediaFrame instead of VideoFrame because I can get the software bitmap only from VideoMediaFrame. Let me know and I will make the change.

you can get a SoftwareBitmap from a VideoFrame: if its SoftwareBitmap is null, you can convert back and forth from Direct3DSurface to SoftwareBitmap easily. I'd would just send back VideoFrame, not SoftwareBitmap or VideoMediaFrame

Both the software bitmap and Direct3DSurface are null when I try to get them video frame.

nmetulev · 2018-04-22T19:46:13Z

Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

@@ -292,6 +293,8 @@
    <Content Include="SamplePages\BluetoothLEHelper\BluetoothLEHelper.png" />
    <Content Include="SamplePages\BackdropBlurBrush\BackdropBlurBrush.png" />
    <Content Include="SamplePages\Blur\BlurBehavior.png" />
+    <Content Include="SamplePages\CameraPreview\Camera.png" />


Can you replace these two with these (CameraPreview and CameraHelper respectively) :

Changed icons

nmetulev · 2018-04-22T19:48:06Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraPreview/CameraPreviewCode.bind

@@ -0,0 +1,40 @@
+<Page xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"


This file should be split into xaml bind file so it can be edited by the user.

Split into separate XAML bind file

nmetulev · 2018-04-22T19:48:50Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

+        /// <summary>
+        /// Event raised when a new software bitmap arrives.
+        /// </summary>
+        public event EventHandler<SoftwareBitmap> SoftwareBitmapArrived;


Agree, there should be one event

nmetulev · 2018-04-22T19:50:03Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

+            _videoPreviewText = (TextBlock)this.GetTemplateChild("VideoPreviewTextBlock");
+            _videoPreviewErrorTextBlock = (TextBlock)this.GetTemplateChild("VideoPreviewErrorTextBlock");
+
+            _frameSourceGroupCombo.SelectionChanged += FrameSourceGroupCombo_SelectionChanged;


Make sure you unsubscribe from this event in the beginning of this method (in case it was subscribed in the previous template)

If the user changes the template, this could be null, make sure to check for null

nmetulev · 2018-04-22T19:54:56Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.xaml

+                        <StackPanel Grid.Row="1" Orientation="Vertical" Margin="0,10">
+                            <TextBlock x:Name="VideoPreviewTextBlock" Text="Video Preview"  Margin="0,0,0,10"></TextBlock>
+                            <TextBlock x:Name="VideoPreviewErrorTextBlock" Style="{StaticResource MessageStyle}"  Margin="0,0,0,10" Visibility="Collapsed"></TextBlock>
+                            <MediaPlayerElement x:Name="MediaPlayerElementControl" MinWidth="300" Width="400" PosterSource="ms-appx:///Assets/Photos/PreviewUnavailable.png" HorizontalAlignment="Left">


This will crash if the developer does not have a png at "Assets/Photos/PreviewUnavailable.png" in their app. Either remove this completly or expose this as a property on your control and do TemplateBinding

nmetulev · 2018-04-22T19:56:12Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.xaml

+                            <RowDefinition Height="Auto"></RowDefinition>
+                            <RowDefinition Height="Auto"></RowDefinition>
+                        </Grid.RowDefinitions>
+                        <ComboBox x:Name="FrameSourceGroupCombo" Header="Frame Source Group" HorizontalAlignment="Left" Width="Auto">


Instead of a ComboBox, what if we just have a simple toggle button on top of the MediaPlayerElement to toggle between sources? We should then have a bool dependancy property to enable and disable the button.

If the user wants to provide a ComboBox, can we expose the list of sources in a read only list?

nmetulev · 2018-04-22T19:57:01Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/CameraHelperResult.cs

+        /// <summary>
+        /// Gets or sets a value indicating whether camera helper initialization was successful or not
+        /// </summary>
+        public bool Status { get; set; }


Or an Enum if there is more than two, and potentialy removing the Message property below

nmetulev · 2018-04-22T19:59:17Z

Microsoft.Toolkit.Uwp/Helpers/CameraHelper/FrameSourceGroupsHelper.cs

+    /// <summary>
+    /// Helper class to get Frame Source Groups that can be used by Media Capture
+    /// </summary>
+    public static class FrameSourceGroupsHelper


Could this whole helper be part of the camera helper and automaticly do this in the inatialization when the camera helper is initialized, simplifying the API?

Modified and moved the code to Camera Helper to simplify initialization.

nmetulev · 2018-04-22T20:01:01Z

docs/controls/CameraPreview.md

+}
+```
+
+## Example


Make sure to follow the docs template for the documentation and inlcude properties (and any other missing sections)

nmetulev · 2018-04-22T20:01:40Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.xaml

+                            </ComboBox.ItemTemplate>
+                        </ComboBox>
+                        <StackPanel Grid.Row="1" Orientation="Vertical" Margin="0,10">
+                            <TextBlock x:Name="VideoPreviewTextBlock" Text="Video Preview"  Margin="0,0,0,10"></TextBlock>


I'd avoid having any text in the control. Instead I'd remove the two textblocks and let the developer handle how they want to show errors. Maybe we can fire an event on error for that purpose?

1. Moved logic from FrameSourceGroupsHelper into Camera Helper and minimalized calling logic to camera helper. 2. Modified Camera preview Control to use toggle button instead of combobox for frame sources 3. Modified to use only one event for frames arrived.

… you acquire a frame

…nt to CameraPreview Control

Merge from original

# Conflicts: # Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj # Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json

…king on source button

…unityToolkit into CameraHelper # Conflicts: # Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

… Preview page to reuse camera helper if one exists.

…esources

michael-hawker · 2018-05-22T21:19:03Z

Provided some feedback offline as was having trouble with GitHub.

…y type instead of by name, that way even if the user changes name of control, preview page will still work. Added TemplatePart attributes to Camera Preview Control

michael-hawker · 2018-05-23T17:48:23Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

+    /// <summary>
+    /// Camera Control to preview video. Can subscribe to video frames, software bitmap when they arrive.
+    /// </summary>
+    [TemplatePart(Name = "MediaPlayerElementControl", Type =typeof(MediaPlayerElement))]


Name should be pulled out as a constant so we can use it here and when we grab it.

…unityToolkit into CameraHelper

azchohfi · 2018-05-23T19:28:52Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraPreview/CameraPreviewPage.xaml.cs

+        {
+            var cameraHelper = _cameraPreviewControl?.CameraHelper;
+            _cameraPreviewControl.PreviewFailed += CameraPreviewControl_PreviewFailed;
+            await _cameraPreviewControl.StartAsync(cameraHelper);


Does it make sense to expose the camera helper for the camera preview control? It should map those events and hide the internal implementation. Why is it the developer who need to provide this?

Camera Helper is exposed so that the user can access properties and events exposed directly from the helper. The developer can either provide a camera helper if they have one created with some settings or use StartAsync() which creates a default camera helper instance.

azchohfi · 2018-05-23T19:33:21Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/CameraPreview/CameraPreviewPage.xaml.cs

+
+        private async void Application_Suspending(object sender, SuspendingEventArgs e)
+        {
+            if (Frame.CurrentSourcePageType == typeof(CameraPreviewPage))


The control should handle it's own cleanup on app suspension and resuming.

But we can do this later. It's fine for a first implementation.

azchohfi · 2018-05-23T19:35:22Z

Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

+    /// <summary>
+    /// Camera Control to preview video. Can subscribe to video frames, software bitmap when they arrive.
+    /// </summary>
+    [TemplatePart(Name = "MediaPlayerElementControl", Type =typeof(MediaPlayerElement))]


old review

REDMOND\sokommir and others added 9 commits April 10, 2018 11:30

Initial checkin- adding camera helper class for capturing frames, Add…

2a6b3d6

…ing a sample page to select frame sources

Cleaning up resources, adding logic to update source and capture video

0c75302

- Added MediaPlayer and hooking it to the frame source

b32d3c5

- Styling for sample page - Get software bitmap and hook it to the Image element - Added placeholder documentation CamerHelper.md - Added camera icon for helper

- Added CameraResult class to return status of Camera Helper Capture …

eb73681

…Initialization and any error messages. - Updated xaml to show error messages.

Updating error message for debugging

7acdac2

- Updated CameraPreviewCode.bind class to check for result from camer…

add873f

…a helper initialization - Updated xaml sample page to hide preview controls etc when no sources are found - fixing clean up resources exception when navigating away from page and no resources are found.

Merge pull request #1 from Microsoft/master

e4db028

Merge from original

Merge branch 'master' into CameraHelper

f60fbf4

Added copyright header for source files

d3468a3

michael-hawker reviewed Apr 16, 2018

View reviewed changes

JohnnyWestlake reviewed Apr 17, 2018

View reviewed changes

Renaming Async methods with Async keyword

803dcd2

Odonno previously requested changes Apr 18, 2018

View reviewed changes

skommireddi added 6 commits April 18, 2018 18:21

Added new custom CameraVideoPreview xaml control

d5a0300

Refactored sample page to use the xaml control Updated styling

Addressing code review comment: changing to auto property initializers

97e00b0

Removing Debug statements per code review comment

ef8a6cf

Added sample page, code bind file and documentation for Camera Previe…

a472edf

…w Control Added doc for Camera Helper class, updated code bind file and sample page

Merge pull request #2 from Microsoft/master

929233b

Merge from original to update fork with latest

Merge branch 'master' into CameraHelper

93aad10

# Conflicts: # Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj

LPBourret suggested changes Apr 22, 2018

View reviewed changes

nmetulev requested changes Apr 22, 2018

View reviewed changes

skommireddi added 8 commits April 23, 2018 13:31

Changing icons for CameraPreview and CameraHelper sample pages

bee2fb1

Addressing more code review comments -Disposing software bitmap after…

aa357e7

… you acquire a frame

Addressing PR review comments - Updated docs, added PreviewFailed eve…

5110904

…nt to CameraPreview Control

Merge pull request #3 from Microsoft/master

1777b7b

Merge from original

Merge branch 'master' into CameraHelper

741c414

# Conflicts: # Microsoft.Toolkit.Uwp.SampleApp/Microsoft.Toolkit.Uwp.SampleApp.csproj # Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json

Adding headers to code files, fixing out of range exception when clic…

815321d

…king on source button

Renamed filename to match type name

9d0b9b8

nmetulev changed the base branch from rel/3.0.0-preview to master May 18, 2018 18:38

skommireddi and others added 7 commits May 18, 2018 12:03

Merge branch 'CameraHelper' of https://github.com/skommireddi/UWPComm…

0547ab6

…unityToolkit into CameraHelper # Conflicts: # Microsoft.Toolkit.Uwp.UI.Controls/CameraPreview/CameraPreview.cs

Adding thread safety to Camera Helper logic. Modified logic in Camera…

884d075

… Preview page to reuse camera helper if one exists.

Fixing an issue with toggle button not finding the correct group

4d37ee1

Merge branch 'master' into CameraHelper

c904aa3

unregistered lifecycle events to prevent memory leak

d3652a7

updated docs

f11291b

cleanup

9ef5c71

nmetulev approved these changes May 21, 2018

View reviewed changes

Updating docs, adding thread safe code for cleaning up CameraHelper r…

718064c

…esources

skommireddi and others added 3 commits May 22, 2018 15:34

Added webcam capability link in docs.

da47ee0

Addressing Michael's comments: Changed logic to find previe control b…

1a81de7

…y type instead of by name, that way even if the user changes name of control, preview page will still work. Added TemplatePart attributes to Camera Preview Control

Merge branch 'master' into CameraHelper

6ca4963

nmetulev added the controls 🎛️ label May 23, 2018

nmetulev added this to the 3.0 milestone May 23, 2018

michael-hawker requested changes May 23, 2018

View reviewed changes

nmetulev and others added 5 commits May 23, 2018 11:03

Merge branch 'master' into CameraHelper

294f05a

Addressing comments: adding constants to refer to Template Part Names

a764de3

Addressing comments

2cd0448

Merge branch 'CameraHelper' of https://github.com/skommireddi/UWPComm…

d06a3b0

…unityToolkit into CameraHelper

Removing unnecessary usings

97487ee

michael-hawker approved these changes May 23, 2018

View reviewed changes

azchohfi requested changes May 23, 2018

View reviewed changes

Updating docs with Dispose() method

12e387e

azchohfi approved these changes May 23, 2018

View reviewed changes

Merge branch 'master' into CameraHelper

e2f556f

nmetulev merged commit b520f44 into CommunityToolkit:master May 23, 2018

		@@ -0,0 +1,40 @@
		<Page xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"

Camera helper WIP #1980

Camera helper WIP #1980

Conversation

skommireddi commented Apr 16, 2018 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

dnfclas commented Apr 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skommireddi Apr 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skommireddi Apr 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LPBourret Apr 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michael-hawker commented May 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skommireddi commented Apr 16, 2018 •

edited

Loading

dnfclas commented Apr 16, 2018 •

edited

Loading

skommireddi Apr 23, 2018 •

edited

Loading

skommireddi Apr 23, 2018 •

edited

Loading

LPBourret Apr 23, 2018 •

edited

Loading