Adding GazeIntegration #2026
Adding GazeIntegration #2026
Conversation
…t/UWPCommunityToolkit into harishsk/gaze-integration
…ion" and "origin/harishsk/gaze-integration"
…age and the element being affected.
…lass declarations.
…ke behaviour, not GazePointer, and that the invokability should be cached within them.
This reverts commit a6aec37.
Petea/gaze progression
…DwayneUWPCTKSandbox
Harishsk/gaze integration
First step to clean up access of members.
Slimming of header files
…gs and updated documentation
Dwayne uwpctk sandbox
| <files> | ||
| <!-- WinMd and IntelliSense files --> | ||
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Output\Win32\Release\Microsoft.Toolkit.Uwp.Input.GazeInteraction.winmd" target="lib\uap10.0"/> | ||
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Output\Win32\Release\Microsoft.Toolkit.Uwp.Input.GazeInteraction.xml" target="lib\uap10.0"/> |
There was a problem hiding this comment.
This should probably be \lib\uap10.0.17134\
@onovotny ?
|
|
||
| <!-- DLLs and resources --> | ||
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Output\ARM\Release\Microsoft.Toolkit.Uwp.Input.GazeInteraction.dll" target="runtimes\win10-arm\native"/> | ||
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Output\ARM\Release\Microsoft.Toolkit.Uwp.Input.GazeInteraction.pri" target="runtimes\win10-arm\native"/> |
There was a problem hiding this comment.
You should be able to put just a single .pri file in the \lib\ folder next to the winmd file
| <Implementation>Microsoft.Toolkit.Uwp.Input.GazeInteraction.dll</Implementation> | ||
| </Reference> | ||
| <ReferenceCopyLocalPaths Include="$(MSBuildThisFileDirectory)..\..\runtimes\win10-$(Lib-Platform)\native\Microsoft.Toolkit.Uwp.Input.GazeInteraction.dll" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
None of this should be necessary. However this should be added:
<ItemGroup Condition="'$(ProjectExt)' != '.vcxproj'">
<SDKReference Include="Microsoft.VCLibs, Version=14.0">
<Name>Visual C++ 2015 Runtime for Universal Windows Platform Apps</Name>
</SDKReference>
</ItemGroup>
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Output\Win32\Release\Microsoft.Toolkit.Uwp.Input.GazeInteraction.dll" target="runtimes\win10-x86\native"/> | ||
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Output\Win32\Release\Microsoft.Toolkit.Uwp.Input.GazeInteraction.pri" target="runtimes\win10-x86\native"/> | ||
|
|
||
| <file src="..\Microsoft.Toolkit.Uwp.Input.GazeInteraction\Microsoft.Toolkit.Uwp.Input.GazeInteraction.targets" target="build\native"/> |
There was a problem hiding this comment.
Shouldn't this be in \build\uap10.0.17134\ ?
There was a problem hiding this comment.
Just updated the nuspec and targets, tested it, and seems to work as expected.
…oft/UWPCommunityToolkit into harishsk/gaze-integration
…harishsk/gaze-integration
|
Updated OMD. This looks great now. |
|
|
||
| BEGIN_NAMESPACE_GAZE_INPUT | ||
|
|
||
| private ref class GazeStats sealed |
There was a problem hiding this comment.
I see this was changed to private, but I don't see the class referenced anywhere. Can we just delete it?
There was a problem hiding this comment.
We will be very shortly (immediately after this release) adding stuff that needs this. Is it okay to leave it in till then?
There was a problem hiding this comment.
Sounds good. Just checking :)
|
|
||
| // Basic filter which performs no input filtering -- easy to | ||
| // use as a default filter. | ||
| public ref class NullFilter sealed : public IGazeFilter |
There was a problem hiding this comment.
All the other filters are internal. Should this be too?
There was a problem hiding this comment.
Yes, Thanks for catching it. I will submit a fix soon.
There was a problem hiding this comment.
That means IGazeFilter and GazeFilterArgs are not use anywhere else either
There was a problem hiding this comment.
Fixed and submitted. I also fixed the PointerState enum with explicit values. Thanks for the careful review.
Please merge if everything else is good. Thanks.
There was a problem hiding this comment.
Looks good, but 3 things that might need addressing:
- NullFilter is public. All other filters aren't.
- There's an enum where the order is important, so it should probably get values explicitly assigned to each
- GazeStats looks like an unused private class (isn't used anywhere outside itself)
|
One more thing: Since |
…and added explicit values to PointerState enum
Issue: #
PR Type
What kind of change does this PR introduce?
Feature
What is the current behavior?
Not applicable
What is the new behavior?
This pull request adds a new library (Microsoft.Toolkit.Uwp.Input.GazeInteraction) for supporting gaze interaction in UWP applications. The library is built on top of RS4 API for eye gaze and makes it easy to add eye gaze interactions to existing and new UWP applications.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information