Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twitter service] support for 280 characters on non streaming api calls #2103

Merged
merged 6 commits into from
May 18, 2018

Conversation

nmetulev
Copy link
Contributor

@nmetulev nmetulev commented May 16, 2018

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Non streaming api calls do not include the full 280 characters of tweets

What is the new behavior?

All api calls now include the full 280 characters

Reference twitter docs: https://developer.twitter.com/en/docs/tweets/tweet-updates

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Contains NO breaking changes

@Odonno
Copy link
Contributor

Odonno commented May 17, 2018

@nmetulev Should we not use extended_tweet property like showed in the example?

@nmetulev
Copy link
Contributor Author

@Odonno, what example?

@azchohfi azchohfi merged commit a506336 into master May 18, 2018
@azchohfi azchohfi deleted the nmetulev/twitter branch May 18, 2018 17:47
@Odonno
Copy link
Contributor

Odonno commented May 18, 2018

The JSON object at the end of this page https://developer.twitter.com/en/docs/tweets/tweet-updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants