Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial Gauge Control: ignore zero and negative values for TickSpacing property #2105

Merged
merged 2 commits into from
May 17, 2018

Conversation

XamlBrewer
Copy link
Contributor

Issue: #2102

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When TickSpacing property is set to zero or a negative value the control enters an infinite loop on drawing.

What is the new behavior?

Control does not draw ticks when TickSpacing <= 0.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [*] Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [*] Contains NO breaking changes

Other information

@nmetulev nmetulev merged commit 6148c63 into CommunityToolkit:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants