Add gaze plus switch support #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
June 11, 2018 10:49
Support is currently using any keyboard button
Allow for arbitrary concept of switch, such that it could come from any source
|
|
peteams
reviewed
Jun 26, 2018
| @@ -109,6 +116,7 @@ DependencyProperty^ GazeInput::RepeatDelayDurationProperty::get() { return s_rep | |||
| DependencyProperty^ GazeInput::DwellRepeatDurationProperty::get() { return s_dwellRepeatDurationProperty; } | |||
| DependencyProperty^ GazeInput::ThresholdDurationProperty::get() { return s_thresholdDurationProperty; } | |||
| DependencyProperty^ GazeInput::MaxDwellRepeatCountProperty::get() { return s_maxRepeatCountProperty; } | |||
| DependencyProperty^ GazeInput::IsSwitchEnabled::get() { return s_isSwitchEnabled; } | |||
There was a problem hiding this comment.
Perhaps rename IsSwitchEnabled and s_isSwitchEnabled to IsSwichEnabledProperty and s_isSwitchEnabledProperty. There are conventions expected and sometimes enforced around the naming of these things.
There was a problem hiding this comment.
Sure thing - good catch.
peteams
reviewed
Jun 26, 2018
| @@ -50,6 +53,13 @@ public void OnXamlRendered(FrameworkElement control) | |||
| gazeButtonControl.StateChanged += GazeButtonControl_StateChanged; | |||
| } | |||
| } | |||
|
|
|||
| gazePointer = GazeInput.GetGazePointer(control.FindParent<Page>()); | |||
There was a problem hiding this comment.
Look at how GetGazePointer is implemented! GetGazePointer(null) might be better, or GetGazePointer(this).
peteams
approved these changes
Jun 26, 2018
harishsk
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2269
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Gaze plus switch is not available.
What is the new behavior?
Gaze plus switch is now available
PR Checklist
Please check if your PR fulfills the following requirements:
Other information