Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddWebAllowedObject to unsupported API list #2286

Conversation

rjmurillo
Copy link
Contributor

Issue: #

MicrosoftDocs/WindowsCommunityToolkitDocs#72

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

The known issues does not include information about a missing WinRT API AddWebAllowedObjects(String, Object) which is not supported.

What is the new behavior?

Documentation includes the unsupported API next to information of the related ObjectForScripting

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

CC: @normesta @ericlaw1979

@rjmurillo rjmurillo added documentation 📃 WebView 🖥️ WPF and WinForms WebView labels Jul 6, 2018
@rjmurillo rjmurillo self-assigned this Jul 6, 2018
Copy link

@ericlaw1979 ericlaw1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@rjmurillo rjmurillo added this to the 3.1 milestone Jul 6, 2018
@nmetulev nmetulev merged commit d06c7ad into CommunityToolkit:master Jul 9, 2018
@nmetulev nmetulev modified the milestones: 3.1, 4.0 Jul 11, 2018
@rjmurillo rjmurillo deleted the WebView/AddWebAllowedObject_doc_update branch July 12, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants