AdvancedCollectionView - Re sort all items when PropertyChanged notifications has no parameters #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
reviewed
Jul 17, 2018
| @@ -485,6 +485,10 @@ private void ItemOnPropertyChanged(object item, PropertyChangedEventArgs e) | |||
|
|
|||
| OnVectorChanged(new VectorChangedEventArgs(CollectionChange.ItemInserted, targetIndex, item)); | |||
| } | |||
| else if (e.PropertyName == "" || e.PropertyName == null) | |||
There was a problem hiding this comment.
you could probably replace this with string.IsNullOrEmpty
nmetulev
approved these changes
Jul 17, 2018
azchohfi
approved these changes
Jul 23, 2018
azchohfi
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2143
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
When you modify an element used by an AdvancedCollectionView and it has the INotifyPropertyChanged interface implemented with the onPropertyChange method without the propertyName parameter, it doesn't resort.That's because the AdvancedColectionView's treatment for PropertyChanged notifications doesn't control the case in which it has an empty or null propertyName, and therefore, ignores the situation.
What is the new behavior?
This control will cover the case which the onPropertyChange method has no propertyName
PR Checklist
Please check if your PR fulfills the following requirements: