Correct issues with ApiInformation implementation #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET applications use a concept of Union WinMD, which is the union of all known types that exist in the Windows SDK that correspond to the MaxVersionTested setting of the app. If you're running the app on a down-level platform, ApiInformation will tell you the API doesn't exist, but .NET can still JIT methods based on the Union WinMD and perform some reflection tasks. If you actually try to call the API you will get a MissingMethodException at runtime because the API doesn't really exist. A different problem can occur if you include a higher-versioned .NET library inside a lower-versioned app and try to run it on the higher-versioned build of the OS. In this case, ApiInformation will succeed because the type exists in the system metadata, but .NET will throw a MissingMethodException at runtime because the type didn't exist in the Union WinMD used to build the app.
rjmurillo
added
bug 🐛
nmetulev
approved these changes
Jul 18, 2018
7 tasks
rjmurillo
commented
Jul 20, 2018
| return string.Empty; | ||
| return ApiInformationExtensions.ExecuteIfPropertyPresent( | ||
| WinRtType, | ||
| "Partition", |
There was a problem hiding this comment.
This should be replaced to, no?
There was a problem hiding this comment.
It was in 193077d
The UserAgent property mistakenly used Partition property
nmetulev
requested changes
Jul 20, 2018
| ApiInformationExtensions.ExecuteIfEventPresent( | ||
| WinRtType, | ||
| "LostFocus", | ||
| () => { _webViewControl.GotFocus -= OnLostFocus; }); |
| ApiInformationExtensions.ExecuteIfEventPresent( | ||
| WinRtType, | ||
| "LostFocus", | ||
| () => { _webViewControl.GotFocus += OnLostFocus; }); |
LostFocus event handler was accidentially wired up to GotFocus event.
nmetulev
approved these changes
Jul 23, 2018
azchohfi
approved these changes
Jul 23, 2018
rjmurillo
restored the
WebView/WebViewControlProcessOptions_put_UserAgent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2306
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Depending on OS/Windows SDK installed, WebView may throw unhandled MissingMethodException.
What is the new behavior?
.NET applications use a concept of Union WinMD, which is the union of all known types that exist in the Windows SDK that correspond to the MaxVersionTested setting of the app. If you're running the app on a down-level platform, ApiInformation will tell you the API doesn't exist, but .NET can still JIT methods based on the Union WinMD and perform some reflection tasks. If you actually try to call the API you will get a MissingMethodException at runtime because the API doesn't really exist.
A different problem can occur if you include a higher-versioned .NET library inside a lower-versioned app and try to run it on the higher-versioned build of the OS. In this case, ApiInformation will succeed because the type exists in the system metadata, but .NET will throw a MissingMethodException at runtime because the type didn't exist in the Union WinMD used to build the app.
The change includes a safer wrapper around
ApiInformationmethods catching theMissingMethodExceptionPR Checklist
Please check if your PR fulfills the following requirements:
Other information
@GraniteStateHacker, @purani FYI
Resolves #2306. Requires #2309 for tests to execute