Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Win32 project to use Insiders SDK 17713 #2308

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

rjmurillo
Copy link
Contributor

Issue: #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Missing API for WebView (ImmersiveView permission)

What is the new behavior?

Updating SDK to latest Insiders released version

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

New Insiders build 17713 should be used with same Insiders build (17713.rs5_release)
@rjmurillo rjmurillo added this to the 4.0 milestone Jul 19, 2018
@rjmurillo rjmurillo self-assigned this Jul 19, 2018
@rjmurillo rjmurillo changed the title Web view/sdk 17713 Update Win32 project to use Insiders SDK 17713 Jul 19, 2018
clairernovotny
clairernovotny previously approved these changes Jul 19, 2018
@clairernovotny
Copy link
Member

Looks like the link isn't live yet. Kevin mentioned it might take a day or so.

@clairernovotny
Copy link
Member

The release notes say this This build of the Windows SDK will only install on Windows 10 Insider Preview builds.

Awaiting clarification since that means it won't work on the hosted build agents.

@rjmurillo
Copy link
Contributor Author

The clarification indicates it will function the same way 17704, which is what we're upgrading from. There are limitations for managed DLLs included with the SDK that will not run because they are delay or test signed. Like 17704, 17713 will install on non-Insiders OS as long as IPOverUSB is also not installed. @onovotny I'd like to take up changes to disable managed assembly verification in a separate PR

@rjmurillo
Copy link
Contributor Author

SDK test signing issue in #2314

@clairernovotny clairernovotny merged commit 767552c into CommunityToolkit:master Jul 19, 2018
@clairernovotny clairernovotny deleted the WebView/SDK_17713 branch July 19, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants